Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Update to use fetch over node-fetch? #938

Open
abdulajet opened this issue Jun 14, 2024 · 0 comments
Open

[Bug]: Update to use fetch over node-fetch? #938

abdulajet opened this issue Jun 14, 2024 · 0 comments
Assignees
Labels
bug A defect in the code Triage Issue needs to be triaged

Comments

@abdulajet
Copy link

abdulajet commented Jun 14, 2024

Node Version

22.x

Platform

Mac (Apple Silcon)

SDK Version

3.14.x

Code Sample

npm install @vonage/server-sdk
// use sdk in a index.js for example
node index.js

Expected Behavior

Runs without deprecation warning for punycode

Actual Behavior

Has deprecation warning for punycode
See node-fetch/node-fetch#1793 (comment)

I think we should be good to remove the node-fetch dependancy since fetch is available in node v18 and upwards (as experimental) and stable in v21. Not sure how experimental it is until v21, so I will leave it to you to decide if its worth making the change yet

@abdulajet abdulajet added bug A defect in the code Triage Issue needs to be triaged labels Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the code Triage Issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

4 participants