Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PHP 8.3 #456

Closed
Brenneisen opened this issue Nov 26, 2023 · 4 comments
Closed

Support for PHP 8.3 #456

Brenneisen opened this issue Nov 26, 2023 · 4 comments
Assignees
Labels
enhancement release-candidate This PR will result in a release work-scheduled This label indicates that the fix/resolution is scheduled into Vonage's workload

Comments

@Brenneisen
Copy link

This library uses legacy dependencies. Since PHP 8.3 is now released, a new major version of this library could be released with support for PHP 8.3. To do this, the dependency of lcobucci/jwt 4.0 would have to be extended to 5.1. The support for lcobucci/jwt 3.4 could also be removed, as this version only supports PHP 7.0 anyway.

In addition, the dependency on ramsey/uuid 3.9 should also be extended to 4.0 so that Laravel users can also use this library.

@SecondeJK
Copy link
Contributor

I'm closing this because you've duplicated it in a new issue

@Brenneisen
Copy link
Author

This is not a duplicate. This topic is about support for PHP 8.3.

@SecondeJK SecondeJK self-assigned this Dec 12, 2023
@SecondeJK
Copy link
Contributor

Apologies, I think the mention of the jwt and uuid libraries has got mixed up with the PHP version.
PHP8.3 cannot be supported until Prophecy releases a new 8.3 compatible version.

This will get merged and released when ready, we already have a PR:
#455

@SecondeJK SecondeJK reopened this Dec 12, 2023
@Brenneisen Brenneisen changed the title PHP 8.3 Support Support for PHP 8.3 Dec 12, 2023
@SecondeJK SecondeJK added enhancement release-candidate This PR will result in a release work-scheduled This label indicates that the fix/resolution is scheduled into Vonage's workload labels Dec 13, 2023
@SecondeJK
Copy link
Contributor

Merged #455. More dependency bumps to come.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement release-candidate This PR will result in a release work-scheduled This label indicates that the fix/resolution is scheduled into Vonage's workload
Projects
None yet
Development

No branches or pull requests

2 participants