Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Web #10

Closed
murtraja opened this issue Mar 26, 2019 · 3 comments
Closed

Support for Web #10

murtraja opened this issue Mar 26, 2019 · 3 comments

Comments

@murtraja
Copy link
Contributor

Hello,

While compiling for web (using react-native-web), I receive this error:

ERROR in ./node_modules/react-navigation-backhandler/index.js
Module not found: Error: Can't resolve './BackHandler' in '/home/wishbook/MMR/code/reactapp/node_modules/react-navigation-backhandler'
 @ ./node_modules/react-navigation-backhandler/index.js 1:204-228
 @ ./app/screens/home/HomeScreen.js
 @ ./app/config/routes.js
 @ ./app/index.js
 @ ./index.web.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 (webpack)/hot/dev-server.js ./node_modules/regenerator-runtime/runtime.js ./index.web.js

This issue is easily fixed by having a BackHandler.web.js file whose contents are same as that of Backhandler.ios.js

Would you like to me submit a PR, so that this library is react-native-web compatible?

@vonovak
Copy link
Owner

vonovak commented Mar 26, 2019

hi @murtraja yes, that would be great, thanks!

@murtraja
Copy link
Contributor Author

#11

@vonovak
Copy link
Owner

vonovak commented Mar 26, 2019

published, thanks!

@vonovak vonovak closed this as completed Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants