Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch: UI proofreading/minor editing #54

Closed
andrei-a-papou opened this issue Feb 23, 2024 · 7 comments
Closed

Patch: UI proofreading/minor editing #54

andrei-a-papou opened this issue Feb 23, 2024 · 7 comments
Milestone

Comments

@andrei-a-papou
Copy link

I've made several patches to fix some inconsistencies in UI strings as well as offer several improvements. Labels now consistently use sentence-case capitalization (first letter only). Some labels have been shortened: I think it's generally a good idea, plus (depending on the terminal geometry and font size) some labels in the Help bar may not fit on screen otherwise.

Some changes may be a bit opinionated though I've tried to avoid these :) Please let me know your thoughts.

99-new-strings-1.diff.gz
99-new-strings-2.diff.gz
99-new-strings-3.diff.gz

@andrei-a-papou
Copy link
Author

andrei-a-papou commented Feb 23, 2024

In addition, in my local repo I've removed the "fancy" return character from the UI. Personally, I prefer the UI to say <return> as it's easier to read (at least with the font I use). But the real reason is consistency: right now, some UI parts say and some say <return>, which I think we should correct either way :) As long as it's consistent, you have my vote :)

99-remove-fancy-return-key.diff.gz

@vonshednob
Copy link
Owner

I full agree: consistency! And not everyone might understand the symbols (especially when it comes to the more obscure ones, like for page down)

@vonshednob vonshednob added this to the Version 3.16 milestone Feb 23, 2024
@andrei-a-papou
Copy link
Author

Yes, but I like the arrow key symbols -- these are intuitive and helpful

@vonshednob
Copy link
Owner

So … partial consistency? UX is not an area where I have a lot of experience. I'm very happy about any advise.

@andrei-a-papou
Copy link
Author

No, you're right. Sorry for a confusing remark. We need consistency throughout. Right now we have <up> on the Help screen, but in the Helpbar. Load search dialog uses , but New task dialog uses <return>.

With the current keys, I don't see a real need the "human-friendly" key translations (under SPECIAL = {}) -- I would say <return> is actually easier to grasp than a single-char . (But it's conceivable that pter will need this kind of translation in the future, for some other keys. Then the translations would need to consistently apply to all UI parts.)

So I guess I would simply eliminate SPECIAL = {} for now.

@andrei-a-papou
Copy link
Author

andrei-a-papou commented Feb 24, 2024

Since you've added help.py, here's a new patch set against https://codeberg.org/vonshednob/pter/commit/0f1a4bcfd045f0123be2604d75e4714a396740a9:

20-new-strings-1.diff.gz
20-new-strings-2.diff.gz

@vonshednob
Copy link
Owner

These are all in place, too.

I cleared almost all SPECIAL translations except for " ": "<space>". That seemed necessary still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants