Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file name completion when searching #62

Closed
andrei-a-papou opened this issue Mar 9, 2024 · 8 comments
Closed

Add file name completion when searching #62

andrei-a-papou opened this issue Mar 9, 2024 · 8 comments
Milestone

Comments

@andrei-a-papou
Copy link

When using multiple todo files, pter can already filter todos by using file: in the search bar. It would be nice if typing file: would show the completion dropdown -- so the user wouldn't have to remember the exact file name.

@vonshednob
Copy link
Owner

Not a bad idea either! Although I don't think you have to provide the exact filename? Just any distinctive part should work? Like, if one file is at documents/project1/todo.txt and another is at shared/work.txt, you should be able to find all issues from the todo.txt by searching for file:pro

@andrei-a-papou
Copy link
Author

You're right, partial matches work! It's no big deal for me with two distinctively named files, but with more files I think it'd be helpful to make things more explicit.

And by the way, I love the fact that pter can seamlessly work with multiple files. It was a fantastic idea. I've used several todo.txt apps in the past and they all can either handle one file at a time or use something like tabs, which is often awkward.

@andrei-a-papou
Copy link
Author

Oh, this seems easy to do:
80-filename-completion.diff.gz

@vonshednob
Copy link
Owner

Wasn't there something about a feature freeze for version 3.16? But then again life happened and I had not have a lot of time to implement all the things… so maybe, just maybe…

@andrei-a-papou
Copy link
Author

andrei-a-papou commented Mar 9, 2024

Oh, this seems easy to do

I spoke too soon: the completion in this case should be limited to search bar only. It doesn't make sense in "Edit task" or "New task" dialogs, for example.

How about this:
80-filename-completion-searchbar.diff.gz

@andrei-a-papou
Copy link
Author

andrei-a-papou commented Mar 10, 2024

And here's a patch to support highlighting {file} in task list:
81-filename-highlighting.diff.gz

@vonshednob
Copy link
Owner

Added! Thanks a lot for amazing help and your time to making pter better 😀

@vonshednob vonshednob added this to the Version 3.16 milestone Mar 12, 2024
@andrei-a-papou
Copy link
Author

Sure thing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants