Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup the bindings layer #738

Closed
14 tasks done
reconbot opened this issue Apr 7, 2016 · 1 comment
Closed
14 tasks done

Cleanup the bindings layer #738

reconbot opened this issue Apr 7, 2016 · 1 comment
Labels
feature-request Feature or Enhancement

Comments

@reconbot
Copy link
Member

reconbot commented Apr 7, 2016 •
edited

For the purposes of this issue, I'm defining the bindings as the SerialPortBindings object the the following functions and the poller.

  • list
  • open
  • update unix
  • update windows
  • write
  • close
  • flush
  • set
  • get
  • drain
  • request for data

I see a few steps to support this.

  • Isolate all the js shims for Bindings from the main serialport code
  • Documenting the binding interfaces
  • Finish normalizing the binding interfaces so we can remove the platform checks from the main code

The current status of binding isolation is as follows.

  • There is no read() method. There are two method of read operations. Linux and OSX use libuv UV_READABLE and windows does a ReadFile loop in c++. Because of this Windows bindings can read the data and call our callbacks, and OSX and Linux repeatedly does a fs.read. We need work out the differences and provide a unified interface.
  • Disconnect events are communicated in different ways between unix and windows
  • A few methods do different things on different platforms (eg flush)
@reconbot reconbot added the feature-request Feature or Enhancement label Apr 7, 2016
This was referenced Apr 7, 2016
Closed
Closed
@reconbot reconbot mentioned this issue May 29, 2016
Merged
@reconbot reconbot closed this as completed Nov 5, 2016
@reconbot
Copy link
Member Author

reconbot commented Nov 5, 2016

Closed by #906

@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature-request Feature or Enhancement
Milestone
No milestone
Development

No branches or pull requests
1 participant
@reconbot