Disable instruction sets when building for linux on ia32 for Galileo support #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify Linux ia32 compile options for Galileo 2
reconbot
changed the title
|
I merged @fivdi's changes to get prebuilt binaries to run on the Galileo. I'm still going to leave this open for now as I'm not sure it's a good idea. We could add this to our precompiled matrix as a separate build but as of right now node and node-pre-gyp see's the Galileo's arch as "ia32" and not "pentium" so it wouldn't grab the right file. |
|
A potential alternative not listed in the OP is to do nothing. It looks like there was only one issue about the topic filed at the serialport repo so far. The workaround on the Galileo 2 would be |
reconbot
added a commit
that referenced
this pull request
May 5, 2016
|
I like the way you think. This btw is a very similar reason to why we don't have arm precompiled binaries. |
reconbot
added a commit
that referenced
this pull request
Jul 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #747 some of the intel boards don't support some instructions and our prebuilt binaries wont run on those platforms. This PR disables a few instruction sets for 32bit linux installations. If these instructions are available but disabled it's a performance hit, if they're not available but enabled they cause an annoying error with little information. I don't have data for what kind of performance hit. I'm actually just assuming.
We can do one of a few things.
cc @rwaldron @jacobrosenthal @fivdi