fix: plugin loading resets variants #330 (#381)

windicss · Jul 12, 2021 · db1facc · db1facc
1 parent 33495a8
commit db1facc
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 1 deletion.
diff --git a/src/lib/index.ts b/src/lib/index.ts
@@ -969,7 +969,7 @@ export class Processor {
     }
     this._config = this._resolveFunction(this._config);
     this._theme = this._config.theme;
-    this._variants = this.resolveVariants();
+    this._variants = { ...this._variants, ...this.resolveVariants() };
     handler(this.pluginUtils);
   }
 

diff --git a/test/interface/__snapshots__/plugin.test.ts.yml b/test/interface/__snapshots__/plugin.test.ts.yml
@@ -26,3 +26,8 @@ Tools / addComponents with attribute selectors / css / 0: |-
     --tw-text-opacity: 0.2;
     color: hsla(var(--bc,215 28% 17%)/var(--tw-text-opacity));
   }
+Tools / variants not cleared when plugin loaded / css / 0: |-
+  .variant .variant\:text-black {
+    --tw-text-opacity: 1;
+    color: rgba(0, 0, 0, var(--tw-text-opacity));
+  }
diff --git a/test/interface/plugin.test.ts b/test/interface/plugin.test.ts
@@ -94,4 +94,21 @@ describe('plugin interface test', () => {
 
     expect(processor.preflight(' ', false, false, true).build()).toMatchSnapshot('css');
   });
+
+  it('variants not cleared when plugin loaded', () => {
+    const processor = new Processor({
+      plugins: [
+        {
+          handler: ({ addVariant }) => {
+            addVariant('variant', ({ parent }) => parent('.variant'));
+          },
+        },
+        {
+          handler: () => {/* Nothing */},
+        },
+      ],
+    });
+
+    expect(processor.interpret('variant:text-black').styleSheet.build()).toMatchSnapshot('css');
+  });
 });