-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continous Deployment (CD) is broken (again) since 3 days #11
Comments
I just had a look at the build last log (and will make it possible for @ptuomola to look at it himself in the future in #10), and it's indeed as @ptuomola suspected an impact of apache/fineract#2009 (apache/fineract@6e052e5) by @vidakovic:
Basically what I do for https://www.fineract.dev is simply (something very much like) a The solution here would be to make Google Cloud Build perform a |
https://github.com/coollog/jib-google-cloud-build/ has something about this, but I believe it's outdated; I've created coollog/jib-google-cloud-build#1 about it (@coollog appears to be the original creator of JIB). GoogleContainerTools/jib#3545 suggests better documenting this on the README of JIB itself. https://github.com/GoogleContainerTools/jib/tree/master/jib-gradle-plugin#using-google-container-registry-gcr makes it sound like this may be simple? https://cloud.google.com/blog/products/application-development/introducing-jib-build-java-docker-images-better mentioned the same PS: A future alternative could perhaps even be doing this through Skaffold, as in https://github.com/GoogleCloudPlatform/microservices-demo/blob/master/cloudbuild.yaml. |
Staring at https://github.com/GoogleCloudPlatform/air-draw-demo/blob/master/cloudbuild.yaml makes me suspect this may be as simple as that... I'll try that. |
Note: at the moment I am only building that Docker image, but the task can also publish to a Docker repo (which that workflow you pointed to does). So, if we already have credentials in place that authenticate Docker GH Actions against such a repo then running just the "jib" task will take care of it (aka publish the image)... without having looked at the deployment workflow in detail. |
Huh, "fun" twist - there does not seem to be a @jamesward @ludoch @glaforge @averikitsch can we connect next week at work (Googler myself writing here) to get this done? It seems like I'm blocked with this issue by that. (Unless there is a workaround I'm not thinking of.) |
The Good alternatives: So like:
Which might not contain what you need to build something, in which case use the following in CI:
|
@jamesward Oh! Right. I assumed, without verifying, that I gather from your comment, and looking at it, that this is not the case (so |
Yes it should just work, assuming that your Cloud Build service account has the right permissions. |
@jamesward FYI a
but using (e.g.) With this, https://demo.fineract.dev/fineract-provider/actuator/info shows the latest commit of https://github.com/apache/fineract again, and I'm closing this issue as resolved. (I've stumbled upon new https://issues.apache.org/jira/browse/FINERACT-1480, which probably broke a while ago, and is not directly related to this.) PS: I'll follow up for JIB with Google Cloud Build in general, unrelated to https://www.fineract.dev per se, in GoogleContainerTools/jib#3545. |
As per feedback from @ptuomola in #4, the CD is broken (again) since 3 days, after it worked following #8.
The goal of this issue is to fix that again.
The text was updated successfully, but these errors were encountered: