Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea, detections are hidden when behind a custom mask #42

Closed
Tinbum1 opened this issue Sep 26, 2020 · 9 comments
Closed

Idea, detections are hidden when behind a custom mask #42

Tinbum1 opened this issue Sep 26, 2020 · 9 comments

Comments

@Tinbum1
Copy link

Tinbum1 commented Sep 26, 2020

At the moment the program still logs detection's in the mask history even if they are hidden behind a custom mask. Might it be a good idea that these are not stored making it easier to go through the relevant dynamic mask detail history and also reducing the size of the json file. It may also reduce processing time? or perhaps not.

@Tinbum1
Copy link
Author

Tinbum1 commented Oct 3, 2020

Also on the Dynamic mask Detail tab/ active masks, when you click on a mask it shows the mask on the image with a description of what it is. Would it be possible to add the 'key' so the mask can be easily identified.

image

@VorlonCD
Copy link
Owner

VorlonCD commented Oct 3, 2020

Sure, look for it in the next update

@Tinbum1
Copy link
Author

Tinbum1 commented Oct 3, 2020

Thank you.

@VorlonCD
Copy link
Owner

Back to your original suggestion, not storing masked items (and potentially false detection) may save some time loading the database but I cant say how much. You would sacrifice the ability to troubleshoot detection's. The latest version is faster, do you think it is worth creation an option for it?

@Tinbum1
Copy link
Author

Tinbum1 commented Oct 11, 2020

Yes, option is great idea. It would help reduce the masks in the Dynamic mask history and active page. I'm getting dynamic masks created for items hidden behind custom masks.

@VorlonCD
Copy link
Owner

Right now the dynamic mask routine is run BEFORE the check if something is masked with the old style image mask. Perhaps it should be the other way around?

@Tinbum1
Copy link
Author

Tinbum1 commented Oct 11, 2020

That sounds logical to swap it.

@VorlonCD
Copy link
Owner

these features working for you ok?

@Tinbum1
Copy link
Author

Tinbum1 commented Oct 13, 2020

Yes brilliant , thank you.

This program is just getting better and better all the time. Thank you for all your hard work and incorporating all our suggested features and the ones your coming up with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants