Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regardless of the file output of ffmpeg, the script considers it a success #4

Open
vorwd opened this issue Nov 26, 2023 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@vorwd
Copy link
Owner

vorwd commented Nov 26, 2023

As long as a the script completes this line:

temp_output_file="${temp_directory}/${filename}-AC2.${extension}"

it seems that it will consider ffmpeg a success, as it has added the file to the $temp_directory, even if it's zero sized and not successfully converted video file.

It will then output this line:

if [ $? -eq 0 ]; then
  echo -e "\n"
  echo "ffmpeg conversion successful. Temp output: $temp_output_file"
  echo "Initiating ffprobe on -AC2 file..."

and move on to the ffprobe-AC2, which results in an error (obviously, as there is no data to probe)

Impact is that the file didn't actually succeed and will end up moving a blank file to the $target_directory. Annoying on its own, but a much bigger oversight If in future iterations, the user wanted to implement an automation for deletion on the original file if a -AC2 ends up in the $target_directory.

@vorwd vorwd self-assigned this Nov 26, 2023
@vorwd vorwd added the bug Something isn't working label Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant