-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README to make the Dependencies instructions clearer #19
Comments
Hi @Benmuiruri, |
Hi @shadmanhere thanks. I'll make the contribution and open a PR |
Hi, @shadmanhere I would like to clarify something. As part of the setup, should the user create a Do I have that correct? Second, the |
Hey @Benmuiruri. I contributed to this project recently.
For |
Thanks @deyemiobaa, I will update the readme accordingly. Just to clarify, should a user copy what is in the .env.sample and copy that into the created .env file? Then replace the REACT_APP_API_KEY with their GitHub token ? |
Hey @Benmuiruri. I already opened a PR to handle this. You can view it here |
haha, nice work. Two of the issues I was planning to do as part of hactoberfest ...have now just been done 😅 I had actually updated the readme, I was just waiting for the clarification before opening the PR. I guess I should find other issues |
😬 Sorry man. I'm sure you'll find something. There's a feature I was thinking of perhaps you can work on it. Custom filter for the issues that have been generated. Users can filter by date or last commit (if that's available in the fetched data) |
That's a good idea. I will check it out |
Hi @Benmuiruri, |
Ohh, alright. let me do that. |
Hello @deyemiobaa 👋 . Thank you for stellar contribution to our open source app. That is an amazing idea. Please do open an issue detailing what you've said here. Cheers and Happy Coding! |
Hi Team,
Great work on creating this amazing tool. I was setting up the project on my machine and I don't think it might be easily understandable to beginners that they need to add a GitHub token to the
label_grouping.js
file.I suggest improving the wording in the dependencies section in the readme file to make it more explicit about what one needs to do.
Also, the linters section mentions creating a
.eslintrc.json
file, but the file already exists. I can also fix that issue since it is updating the Readme.I would be happy to make the improvement.
The text was updated successfully, but these errors were encountered: