Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrobbling anime with the same english title as romaji doesn't work #13

Closed
reitenth opened this issue Apr 16, 2022 · 4 comments
Closed

Comments

@reitenth
Copy link

for example, Aharen-san wa Hakarenai has the same english title and romaji title on anilist and it never scrobbles. another example is dance dance danseur. thanks for the help.

@vosmiic
Copy link
Owner

vosmiic commented Apr 17, 2022

Hmm that is strange. It should be able to match up the names.
Is the name in Jellyfin exactly "Aharen-san wa Hakarenai"? Also could you please attach the logs of Jellyfin showing the plugins actions?

@reitenth
Copy link
Author

reitenth commented Apr 17, 2022

Yes, they are named the exact same. Here is what the logs say for each entry. I thought maybe it had to do with the total episodes being unknown for both shows, but Kaguya-sama worked fine and it has an unreleased total episode count as well. All of them are in my currently watching as well. Thanks.


[2022-04-16 02:46:50.580 +00:00] [INF] [115] jellyfin_ani_sync.ServerEntry: (AniList) Found matching series: Aharen-san wa Hakarenai
[2022-04-16 02:46:50.581 +00:00] [INF] [115] jellyfin_ani_sync.ServerEntry: (AniList) Watched episode passes total episodes in season! Checking for additional seasons/cours...
[2022-04-16 02:46:50.581 +00:00] [INF] [115] jellyfin_ani_sync.ServerEntry: (AniList) Attempting to get season 1...
[2022-04-16 02:46:50.671 +00:00] [INF] [6] jellyfin_ani_sync.ServerEntry: (AniList) Could not find any related anime
[2022-04-16 02:46:50.672 +00:00] [WRN] [6] jellyfin_ani_sync.ServerEntry: (AniList) Could not find next season


[2022-04-16 19:31:49.116 +00:00] [INF] [102] jellyfin_ani_sync.ServerEntry: (AniList) Found matching series: Aoashi
[2022-04-16 19:31:49.117 +00:00] [INF] [102] jellyfin_ani_sync.ServerEntry: (AniList) Watched episode passes total episodes in season! Checking for additional seasons/cours...
[2022-04-16 19:31:49.117 +00:00] [INF] [102] jellyfin_ani_sync.ServerEntry: (AniList) Attempting to get season 1...
[2022-04-16 19:31:49.234 +00:00] [INF] [81] jellyfin_ani_sync.ServerEntry: (AniList) Could not find any related anime
[2022-04-16 19:31:49.235 +00:00] [WRN] [81] jellyfin_ani_sync.ServerEntry: (AniList) Could not find next season


[2022-04-16 19:58:38.112 +00:00] [INF] [83] jellyfin_ani_sync.ServerEntry: (AniList) Found matching series: Kaguya-sama: Love is War
[2022-04-16 19:58:38.113 +00:00] [INF] [83] jellyfin_ani_sync.ServerEntry: (AniList) Attempting to get season 1...
[2022-04-16 19:58:38.219 +00:00] [INF] [83] jellyfin_ani_sync.ServerEntry: (AniList) Attempting to get season 2...
[2022-04-16 19:58:38.352 +00:00] [INF] [100] jellyfin_ani_sync.ServerEntry: (AniList) Attempting to get season 3...
[2022-04-16 19:58:38.451 +00:00] [INF] [100] jellyfin_ani_sync.ServerEntry: (AniList) Season being watched is Kaguya-sama: Love is War -Ultra Romantic-
[2022-04-16 19:58:38.549 +00:00] [INF] [100] jellyfin_ani_sync.ServerEntry: (AniList) Series (Kaguya-sama: Love is War -Ultra Romantic-) found on plan to watch list
[2022-04-16 19:58:38.691 +00:00] [INF] [100] jellyfin_ani_sync.ServerEntry: (AniList) Updated series (Kaguya-sama: Love is War -Ultra Romantic-) progress to 2
[2022-04-16 19:58:38.691 +00:00] [INF] [100] jellyfin_ani_sync.ServerEntry: (AniList) Series (Kaguya-sama: Love is War -Ultra Romantic-) not found in plan to watch list, checking completed list..

@vosmiic
Copy link
Owner

vosmiic commented Apr 18, 2022

Okay, I have worked out where the problem is.
We have recently added support for multi-cour shows, which kicks-in when the number of episodes you have watched passes the total number of episodes the anime has (according to the API).
When a show is being aired, AniList returns null for the total number of episodes. The plugin interprets null as 0, therefore if you are watching episode 3, it thinks "3 is larger than 0, therefore they must be watching a multi-cour show".
It is not behaving like this with Kaguya because it is the 3rd season and the multi-cour functionality does not kick in when watching a multi-season show.
Going to set this as a priority to work on, and will be back to you with a solution soon.

@vosmiic
Copy link
Owner

vosmiic commented Apr 18, 2022

Okay I have come up with a solution so that if the show is currently airing and the episode count received from the API is 0, the episode count is ignored and so is processed normally.
I have released a new version of the plugin with this fix, if you still have the problem (I have tested it but I obviously cannot test all edge cases) please do let me know.

@vosmiic vosmiic closed this as completed Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants