-
Notifications
You must be signed in to change notification settings - Fork 0
Review of VOTCA actions #4
Comments
The setup.sh script is missing a description at the top illustrating how it should be called, what arguments should be passed to it. |
Can you explain what this is doing?
You are checking if the branch is a valid branch, and also allowing a user to override what branch to use if it is passed in as an option to setup.sh? |
These die commands could probably be a little more helpful
Could not determine module from CMakeLists.txt file, no project(votca-....) found
die "Unknown INPUT_TOOLCHAIN ${INPUT_TOOLCHAIN}" |
What is the purpose of this:
|
Can you just a make a PR? |
https://github.com/votca/actions/blob/master/setup/action.yml#L3-L41 |
We are figuring out what base branch to use for votca/votca and other checks, e.g. some CMake options only work on the |
If we are doing a module build, install stuff in a different prefix. The module builds installs stuff in the build step and as we don't run the build with |
For the trivial changes. |
Is this still relevant? @junghans |
Are you guys happy with the documentation now? |
Review and create documentation for clarifying build system.
The text was updated successfully, but these errors were encountered: