Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot run with older node version (<=10) #195

Closed
1 of 3 tasks
nandiheath opened this issue Apr 2, 2020 · 6 comments
Closed
1 of 3 tasks

cannot run with older node version (<=10) #195

nandiheath opened this issue Apr 2, 2020 · 6 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@nandiheath
Copy link
Collaborator

Note: for support questions, please use stackoverflow. This repository's issues are reserved for feature requests and bug reports.

  • I'm submitting a ...

    • bug report
    • feature request
    • support request => Please do not submit support request here, see note at the top of this template.
  • What is the current behavior?
    Failed to build on node10

  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)

Probably this is because we are using string.matchAll which is a node12 function. We better find an alternative for this.

@nandiheath nandiheath added bug Something isn't working good first issue Good for newcomers labels Apr 2, 2020
@wingkwong
Copy link
Member

@nandiheath Gatsby requires Node.js 10.13.0 or higher

@cswbrian
Copy link
Collaborator

cswbrian commented Apr 2, 2020

@yookoala
Copy link
Contributor

yookoala commented Apr 3, 2020

I think you may add a .nvmrc file to hint the node version, then add "using nvm" into the recommended practice in README somwhere. There is even a nvm for windows project that supports workflow similar to nvm (which supports Linux and Mac). So you may have all platforms covered. It's always nightmare-ish to use OS-bounded node version anyway.

@nandiheath
Copy link
Collaborator Author

yeah but what I mean is we shouldn't scarify the node 10 compatibility just because of a simple string.matchAll function, which we can easily replace with other implementation.

And I am not opposed to add .nvmrc and specify the version in README 😀

@wingkwong
Copy link
Member

I'm revising README.md. I'll include the version in it.

@wingkwong
Copy link
Member

Closing this issue as it's been handled in 0b275bf, 08be4e8 and 174f007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants