Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emojis Controller #29

Closed
sumityadav opened this issue Jun 18, 2017 · 1 comment
Closed

Emojis Controller #29

sumityadav opened this issue Jun 18, 2017 · 1 comment

Comments

@sumityadav
Copy link
Contributor

Is there a reason why you used a json string and then json_decode it to an array and then return the array as json response?

We could easily create the array and return directly. Laravel would create a Json response automatically.

We can create a migration and seeder to store the emojis in database and cache it in Redis. Thoughts?

@saleh-old
Copy link
Contributor

That EmojisController.php file is probably the "dirtiest" file written by me! And I haven't touched it ever since I wrote it. We could do some cleaning it.

As for the migration and seeder, that sounds more professional and also more work while I don't see any benefits in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants