Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for named timezones #458

Closed
jennifertlovell opened this issue Oct 23, 2023 · 1 comment · Fixed by #457
Closed

Allow for named timezones #458

jennifertlovell opened this issue Oct 23, 2023 · 1 comment · Fixed by #457

Comments

@jennifertlovell
Copy link
Contributor

VIP spec requires UTC offset for structured hours in TimeWithZone element. Update in #457 relaxes regex, allowing for named timezones to be used instead of UTC offset. Proposed change, as currently written, is very permissive. Named timezone validation (validating that the value matches with an existing IANA timezone) will therefore not take place in XML validation. Should discuss other validation steps and where this falls in the workflow, or if we want to use a more strict approach.
@jennifertlovell jennifertlovell linked a pull request Oct 23, 2023 that will close this issue
allow for named timezones #457
Merged
@jungshadow
Copy link
Collaborator

Hi @jennifertlovell! Long-time lurker here given our connection to the project, the NIST CDFs, and the interest in our standards converging. Regarding the latter, this change would be impossible for us to support. VIP's TimeWithZone element is based on xsd:string, but the NIST CDF elements are based on xsd:time. If we wanted to support this, we'd have to weaken the existing typing, which isn't the approach we want to take considering system interoperability. Plus, as you noted, validation could get extremely tricky. Given that, can I ask what the motivation is for this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow for named timezones votinginfoproject/vip-specification
2 participants
@jungshadow @jennifertlovell