Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow text-entry for sample size #112

Closed
umbernhard opened this issue Sep 6, 2019 · 3 comments
Closed

Allow text-entry for sample size #112

umbernhard opened this issue Sep 6, 2019 · 3 comments
Assignees

Comments

@umbernhard
Copy link
Contributor

Rather than force users to pick one of our radio buttons, we should allow text entry of arbitrary sample sizes. E.g. if 323 ballots is the 80% sample, and 375 ballots is the 90%, users should be able to pick 350 ballots (or anything else).

@MorganLove
Copy link
Contributor

@umbernhard So we could have an 'other' or 'custom' option in the radio selection, and when it is selected enable a number input next to it (and disable it when one of the other radios are selected of course). Are there any sanity checks that would need to be applied? (Like we can't have a sample size greater than the number of ballots, etc.)

@MorganLove MorganLove self-assigned this Sep 9, 2019
@umbernhard
Copy link
Contributor Author

umbernhard commented Sep 9, 2019

@MorganLove see #113 re: input validation

I think that sounds like a good plan but defer to @mcchilders

@MorganLove
Copy link
Contributor

Closing in favor of #124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants