Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling duplicate sample size options #70

Closed
MorganLove opened this issue Jul 28, 2019 · 2 comments · Fixed by #78
Closed

Handling duplicate sample size options #70

MorganLove opened this issue Jul 28, 2019 · 2 comments · Fixed by #78

Comments

@MorganLove
Copy link
Contributor

When providing a contest with choice A: 10 votes, choice B: 20 votes, and total ballots as 30 votes, we receive the following sample size options:

Screen Shot 2019-07-27 at 6 41 42 PM

Having multiple radio select options with the same value confuses the browser about which radio button to show as selected when any of them is clicked on (though it doesn't affect the functionality of the form submission). The workaround is very hacky and not recommended practice. However, it seems to be not be an ideal user experience to have multiple options with the same value and different probabilities anyway.

I recommend reducing down options that have the same size value (using the highest prob value of them) to prevent this being confusing for anyone, if this should arise in the real world. This could also be an extreme edge case that we don't need to worry about. Opinions?

@benadida
Copy link
Collaborator

I suspect this isn't going to happen in realistic scenarios, but I defer to Monica.

@benadida
Copy link
Collaborator

@MorganLove maybe we should do what you propose. Small bit of work, and will cover small test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants