Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing semicolon in example configuration files #408

Closed
jblang opened this issue Aug 6, 2021 · 2 comments
Closed

Missing semicolon in example configuration files #408

jblang opened this issue Aug 6, 2021 · 2 comments

Comments

@jblang
Copy link

jblang commented Aug 6, 2021

This commented line is missing a semicolon: https://github.com/vouch/vouch-proxy/blob/master/examples/nginx/single-file/nginx_with_vouch_single_server.conf#L84

I uncommented it because I wasn't seeing X-Vouch-User in my headers but then nginx refused to start with a very unhelpful error message:

nginx: [emerg] invalid number of arguments in "auth_request_set" directive in /etc/nginx/conf.d/default.conf:58

It took me a lot of head scratching before I noticed the semicolon was missing. It's actually missing in several other examples and the README:

~/repos/vouch-proxy$ git grep -n upstream_http_x_vouch_user | grep '[^;]$'
README.md:144:      #    auth_request_set $auth_resp_x_vouch_user $upstream_http_x_vouch_user
examples/OpenResty/conf.d/app1.yourdomain.com.conf:52:      #    auth_request_set $auth_resp_x_vouch_user $upstream_http_x_vouch_user
examples/OpenResty/conf.d/app2.yourdomain.com.conf:52:      #    auth_request_set $auth_resp_x_vouch_user $upstream_http_x_vouch_user
examples/nginx/multi-file/conf.d/app1.yourdomain.com.conf:44:      #    auth_request_set $auth_resp_x_vouch_user $upstream_http_x_vouch_user
examples/nginx/multi-file/conf.d/app2.yourdomain.com.conf:44:      #    auth_request_set $auth_resp_x_vouch_user $upstream_http_x_vouch_user
examples/nginx/single-file/nginx_basic.conf:74:          #    auth_request_set $auth_resp_x_vouch_user $upstream_http_x_vouch_user
examples/nginx/single-file/nginx_with_vouch.conf:73:        #    auth_request_set $auth_resp_x_vouch_user $upstream_http_x_vouch_user
examples/nginx/single-file/nginx_with_vouch_single_server.conf:84:          #    auth_request_set $auth_resp_x_vouch_user $upstream_http_x_vouch_user
examples/nginx/single-file/nginx_with_vouch_ssl.conf:72:        #    auth_request_set $auth_resp_x_vouch_user $upstream_http_x_vouch_user
@bnfinet bnfinet closed this as completed in e553b21 Aug 7, 2021
@bnfinet
Copy link
Member

bnfinet commented Aug 7, 2021

@jblang thanks!

@jblang
Copy link
Author

jblang commented Aug 7, 2021

Thanks for fixing, but you missed the one on line 144 the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants