We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This commented line is missing a semicolon: https://github.com/vouch/vouch-proxy/blob/master/examples/nginx/single-file/nginx_with_vouch_single_server.conf#L84
I uncommented it because I wasn't seeing X-Vouch-User in my headers but then nginx refused to start with a very unhelpful error message:
X-Vouch-User
nginx: [emerg] invalid number of arguments in "auth_request_set" directive in /etc/nginx/conf.d/default.conf:58
It took me a lot of head scratching before I noticed the semicolon was missing. It's actually missing in several other examples and the README:
~/repos/vouch-proxy$ git grep -n upstream_http_x_vouch_user | grep '[^;]$' README.md:144: # auth_request_set $auth_resp_x_vouch_user $upstream_http_x_vouch_user examples/OpenResty/conf.d/app1.yourdomain.com.conf:52: # auth_request_set $auth_resp_x_vouch_user $upstream_http_x_vouch_user examples/OpenResty/conf.d/app2.yourdomain.com.conf:52: # auth_request_set $auth_resp_x_vouch_user $upstream_http_x_vouch_user examples/nginx/multi-file/conf.d/app1.yourdomain.com.conf:44: # auth_request_set $auth_resp_x_vouch_user $upstream_http_x_vouch_user examples/nginx/multi-file/conf.d/app2.yourdomain.com.conf:44: # auth_request_set $auth_resp_x_vouch_user $upstream_http_x_vouch_user examples/nginx/single-file/nginx_basic.conf:74: # auth_request_set $auth_resp_x_vouch_user $upstream_http_x_vouch_user examples/nginx/single-file/nginx_with_vouch.conf:73: # auth_request_set $auth_resp_x_vouch_user $upstream_http_x_vouch_user examples/nginx/single-file/nginx_with_vouch_single_server.conf:84: # auth_request_set $auth_resp_x_vouch_user $upstream_http_x_vouch_user examples/nginx/single-file/nginx_with_vouch_ssl.conf:72: # auth_request_set $auth_resp_x_vouch_user $upstream_http_x_vouch_user
The text was updated successfully, but these errors were encountered:
e553b21
@jblang thanks!
Sorry, something went wrong.
Thanks for fixing, but you missed the one on line 144 the readme.
No branches or pull requests
This commented line is missing a semicolon: https://github.com/vouch/vouch-proxy/blob/master/examples/nginx/single-file/nginx_with_vouch_single_server.conf#L84
I uncommented it because I wasn't seeing
X-Vouch-User
in my headers but then nginx refused to start with a very unhelpful error message:It took me a lot of head scratching before I noticed the semicolon was missing. It's actually missing in several other examples and the README:
The text was updated successfully, but these errors were encountered: