Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow /validate to returns headers with claims #97

Closed
artagel opened this issue Apr 6, 2019 · 4 comments
Closed

Allow /validate to returns headers with claims #97

artagel opened this issue Apr 6, 2019 · 4 comments

Comments

@artagel
Copy link
Contributor

artagel commented Apr 6, 2019

If #95 is implemented, we can provide a fully customizable interface for sending headers down to the proxies application.

@bnfinet
Copy link
Member

bnfinet commented Apr 9, 2019

This is certainly something we've talked quite a bit and that I'm fully in support of.

Were you able to look at the performance for mappedClaims and returning headers from /validate in #90?

The SLA we've set is "less than 1ms" but my hope is to stay closer to the 0.5ms we're at now (on reasonable hardware).

Really /validate performance should be a unit test with mocking of the IdP but we're not there yet.

@artagel
Copy link
Contributor Author

artagel commented Apr 9, 2019

No, I'll try to find a good way to measure the performance impact.

@artagel
Copy link
Contributor Author

artagel commented Apr 13, 2019

After discussion on IRC, we want to accomplish the following:

  1. Add custom claim support
  2. Add it to the JWT instead of the user struct
  3. pass them down to nginx using X-Vouch-IdP-Claims-"claim"
  4. Add config item vouch.headers.claims

@bnfinet
Copy link
Member

bnfinet commented May 3, 2019

fixed in #102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants