fix: react warn if we try to get ref of pure component

vovkasm · Jun 24, 2017 · ffadc1e · ffadc1e
1 parent 6449d80
commit ffadc1e
Showing 1 changed file with 16 additions and 7 deletions.
diff --git a/src/stylable.js b/src/stylable.js
@@ -19,9 +19,15 @@ function getDisplayName (comp) {
   return 'Component'
 }
 
+function isPureComponent (comp) {
+  const p = comp.prototype
+  return p.isPureReactComponent || !p.setState
+}
+
 export default function stylable (name) {
   return function wrapWithComponent (WrappedComponent) {
     const stylableDisplayName = `Stylable(${getDisplayName(WrappedComponent)})`
+    const pureComponent = isPureComponent(WrappedComponent)
 
     class Stylable extends React.Component {
       static displayName = stylableDisplayName
@@ -60,20 +66,23 @@ export default function stylable (name) {
         this.setState({ childProps: this.node.getChildProps() })
       }
 
-      render () {
-        return React.createElement(WrappedComponent, {
-          ...this.state.childProps,
-          ref: this._setWrappedRef
-        })
-      }
-
       _setWrappedRef = (el) => { this._wrapped = el }
 
       getChildContext () {
         return { styleNode: this.node }
       }
     }
 
+    if (pureComponent) {
+      Stylable.prototype.render = function render () {
+        return React.createElement(WrappedComponent, this.state.childProps)
+      }
+    } else {
+      Stylable.prototype.render = function render () {
+        return React.createElement(WrappedComponent, { ...this.state.childProps, ref: this._setWrappedRef })
+      }
+    }
+
     const proto = WrappedComponent.prototype
     if (typeof proto.setNativeProps === 'function') {
       Stylable.prototype.setNativeProps = function (props) {