Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images with White Background Render Off-White (Android) #17

Open
jcady opened this issue Dec 6, 2017 · 2 comments
Open

Images with White Background Render Off-White (Android) #17

jcady opened this issue Dec 6, 2017 · 2 comments

Comments

@jcady
Copy link

jcady commented Dec 6, 2017

I've noticed that images that have a white background do not render the color properly when using this library (on Android). Here are some screenshots of my app putting an image on a white background from stock RN component and this library:

Stock:
rn_image

react-native-web-image:
rn_web_image

Source image:
f69ca69857

@vovkasm vovkasm added the bug label Dec 6, 2017
@jcady
Copy link
Author

jcady commented Dec 12, 2017

I fixed this by upgrading Glide to v4.

bumptech/glide#1589

@vovkasm
Copy link
Owner

vovkasm commented Dec 12, 2017

Thanks! Good to know! Yes glide v3 defaults to RGB_565 format, but v4 to ARGB_8888 https://bumptech.github.io/glide/doc/migrating.html#decodeformat

Meanwhile I hope to make glide v4 near weekend, wip branch feature/update-glide (it works, but I should test carefully)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants