Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teardown #14

Closed
cloudhead opened this issue Aug 3, 2010 · 13 comments
Closed

teardown #14

cloudhead opened this issue Aug 3, 2010 · 13 comments

Comments

@cloudhead
Copy link

We need a teardown stage.

@qrush
Copy link

qrush commented Aug 24, 2010

(+1) Just sticking it into topic now, feels ugly.

@cloudhead
Copy link
Author

I just pushed a new version (0.5.1) with basic teardown support. It's really simple, so it might still need some revisions, but it would be nice to get some feedback on it.

Usage is simple:

teardown: function (topic) { ... }

The teardown will be run after the assertion functions in its context, independently of where it's placed.

@luebken
Copy link

luebken commented Sep 6, 2010

Works great for me. A documentation update would help.

@koudelka
Copy link

It looks like the teardown function doesn't wait until sub-contexts have completed their tests. Is that intentional?

@cloudhead
Copy link
Author

@koudelka, that's the expected behavior, yes. Having it happen after sub-contexts would be useful, and what I wanted initially, but it's much more complex, so it'll have to wait.

@leei
Copy link

leei commented Nov 12, 2010

+1 for the 'after subcontexts' teardown. The teardown is pretty useless if there are such subcontexts, since they almost certainly depend on the state established by the enclosing topic (e.g. setting up a redis connection).

@paulbjensen
Copy link

+1 for doc update. Needed this feature real badly, glad to see it's there.

@alexgorbatchev
Copy link

we also need a teardown/startup for the bundle (ie spin up an http server and shut it down at the end)

@seebees
Copy link

seebees commented Nov 20, 2011

@cloudhead, this looks like it's done. sub-contexts and all. I don't see the documentation in the project but I think all that this issue can be closed? And the documentation be updated? Not sure how to help with that...

@afeld
Copy link

afeld commented May 3, 2012

+1 on documentation needed

@dervalp
Copy link

dervalp commented Jun 2, 2012

+1 for documentation :)

@indexzero
Copy link

Going to leave this open as a documentation bug.

@indexzero
Copy link

Actually going to close this as a duplicate of #214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests