-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
teardown #14
Comments
(+1) Just sticking it into topic now, feels ugly. |
I just pushed a new version (0.5.1) with basic teardown support. It's really simple, so it might still need some revisions, but it would be nice to get some feedback on it. Usage is simple:
The teardown will be run after the assertion functions in its context, independently of where it's placed. |
Works great for me. A documentation update would help. |
It looks like the teardown function doesn't wait until sub-contexts have completed their tests. Is that intentional? |
@koudelka, that's the expected behavior, yes. Having it happen after sub-contexts would be useful, and what I wanted initially, but it's much more complex, so it'll have to wait. |
+1 for the 'after subcontexts' teardown. The teardown is pretty useless if there are such subcontexts, since they almost certainly depend on the state established by the enclosing topic (e.g. setting up a redis connection). |
+1 for doc update. Needed this feature real badly, glad to see it's there. |
we also need a teardown/startup for the bundle (ie spin up an http server and shut it down at the end) |
@cloudhead, this looks like it's done. sub-contexts and all. I don't see the documentation in the project but I think all that this issue can be closed? And the documentation be updated? Not sure how to help with that... |
+1 on documentation needed |
+1 for documentation :) |
Going to leave this open as a documentation bug. |
Actually going to close this as a duplicate of #214 |
We need a teardown stage.
The text was updated successfully, but these errors were encountered: