Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added RHEL7 install for fiftyone-db #1118

Merged
merged 2 commits into from
Jul 12, 2021
Merged

Conversation

AmineDiro
Copy link
Contributor

Fix

This patch fixes the install issue #1097 when installing fiftyone on RHEL7.
The changes include adding download url option to the db package's setup.py for rhel7 distribution.

MONGODB_DOWNLOAD_URLS = {
    "linux-x86_64": "https://fastdl.mongodb.org/linux/mongodb-linux-x86_64-ubuntu1804-4.4.2.tgz",
    "linux-aarch64": "https://fastdl.mongodb.org/linux/mongodb-linux-aarch64-ubuntu1804-4.4.2.tgz",
    "mac": "https://fastdl.mongodb.org/osx/mongodb-macos-x86_64-4.4.2.tgz",
    "win": "https://fastdl.mongodb.org/windows/mongodb-windows-x86_64-4.4.2.zip",
    "ubuntu1604": {
        "manylinux1_x86_64": "https://fastdl.mongodb.org/linux/mongodb-linux-x86_64-ubuntu1604-4.4.2.tgz",
    },
    "debian9": {
        "manylinux1_x86_64": "https://fastdl.mongodb.org/linux/mongodb-linux-x86_64-debian92-4.4.2.tgz",
    },
    "rhel7": {
        "manylinux1_x86_64": "https://fastdl.mongodb.org/linux/mongodb-linux-x86_64-rhel70-4.4.2.tgz",
    },
}

Tests

This patch was testing by creating a local wheel package add installing it using docker test-envs for Centos7.

FROM centos:7

RUN yum install -y python3-devel python3-pip gcc

ENV PATH="/root/.local/bin:${PATH}"

RUN pip3 install --user --upgrade pip setuptools wheel

WORKDIR /test

Added a tab in docs/getting-started/troubleshooting for rhel7 install fix.

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

@brimoor brimoor requested review from benjaminpkane and a team July 11, 2021 21:39
@brimoor brimoor added enhancement Code enhancement setup Package/system setup and configuration labels Jul 11, 2021
Copy link
Contributor

@benjaminpkane benjaminpkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I just published the package.

pip install fiftyone-db-rhel7

To make this PR complete, can you just add the build and upload steps for rhel to our build-db workflow?

Essentially, just add this ad the [debian9 build wheel step]( debian9 step#L64):

      - name: Build wheel (RHEL/CentOS 7 x86_64)
        env:
          FIFTYONE_DB_BUILD_LINUX_DISTRO: rhel7
        run: |
          cd package/db
          python setup.py bdist_wheel --plat-name linux-x86_64

And this after the debia9 upload step:

      - name: Upload wheel (RHEL/CentOS 7)
        uses: actions/upload-artifact@v2
        with:
          name: wheel-rhel7
          path: package/db/dist/*rhel7*.whl

@AmineDiro
Copy link
Contributor Author

Thanks for your guidance, i added the necessary steps to the build. Hope everything is fine.

I'm also working on a tutorial on Fiftyone with MLFlow integration, hope i can share it soon.

@benjaminpkane benjaminpkane merged commit 4001cae into voxel51:develop Jul 12, 2021
@brimoor
Copy link
Contributor

brimoor commented Jul 12, 2021

I'm also working on a tutorial on Fiftyone with MLFlow integration, hope i can share it soon.

@AmineDiro thanks for your contribution! The MLflow integration sounds amazing too 💯 💯 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Code enhancement setup Package/system setup and configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants