Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thoughts and evolutions of the Things API #2

Closed
acs opened this issue Apr 12, 2020 · 3 comments
Closed

Thoughts and evolutions of the Things API #2

acs opened this issue Apr 12, 2020 · 3 comments

Comments

@acs
Copy link
Contributor

acs commented Apr 12, 2020 •
edited

  • Convert Object to Thing as the base class ok
  • Add full_size and init_position as read only params in a Thing
    • size is a method/verd
    • orig_pos is a private constant
@acs
Copy link
Contributor Author

acs commented Apr 13, 2020

Remove the block type from the API ... it is just another optional property (it can be a default block, like BRICK).

@acs
Copy link
Contributor Author

acs commented Apr 14, 2020

#11

Just missing the size method, basic for composing different things!

@acs
Copy link
Contributor Author

acs commented Apr 15, 2020

I have decided to add a end_position property which must be filled after the build when it is supported. All done here and improved the doc also.

@acs acs closed this as completed Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@acs