Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] add a trailing slash to preview/publish urls #394

Open
pardo-bsso opened this issue Dec 20, 2016 · 2 comments
Open

[question] add a trailing slash to preview/publish urls #394

pardo-bsso opened this issue Dec 20, 2016 · 2 comments

Comments

@pardo-bsso
Copy link
Contributor

Hi again,

some of our blueprints use relative references to resources (we want them to be self contained) and without adding a trailing slash to the preview and publish urls this breaks, as the browser tries to load them considering the server root as base url.

For now I've hacked it inside url_for() in lib/autotune/deployer.rb but I'd like to know if there's a better way to do this.

Thanks

@ryanmark
Copy link
Contributor

I believe there is a switch or setting in there somewhere to add or omit the trailing slash. But I can't remember off the top of my head.

When deploying to S3 you need to always have the trailing slash, but when autotune deploys to our CMS it has to omit the trailing slash, so I thought we made that an option somewhere.

@pardo-bsso
Copy link
Contributor Author

I believe there is a switch or setting in there somewhere to add or omit the trailing slash. But I can't remember off the top of my head.

When deploying to S3 you need to always have the trailing slash, but when autotune deploys to our CMS it has to omit the trailing slash, so I thought we made that an option somewhere.

I'll give another read at the codebase, probably I missed it.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants