Using "pruneSessionInterval=false" will unexpectedly disable "createTableIfMissing=true"

[Reiddd]

Hi :)

I meet a weird issue in my product with connect-pg-simple 7.0.0. Here is my code

import PostgresStoreFactory from 'connect-pg-simple';
import session from 'express-session';

const PostgresStore = PostgresStoreFactory(session);
this.store = new PostgresStore({
  pool: pgPool,
  createTableIfMissing: true,
  errorLog: (...args) => {
    logger.error('Postgres session backend error:', ...args);
  },
  pruneSessionInterval: false,
});

Normally I would expect that the session table can be automatically created since I specified createTableIfMissing=true, but in fact it's not.

Error: relation "session" does not exist

Removing pruneSessionInterval=false fixes it, but I think these two parameters should not have dependency on each other, so this looks like a bug to me.

[voxpelli]

This is odd, as all the integration tests for the auto-creation of tables are run with pruneSessionInterval: false, see

node-connect-pg-simple/test/integration/basic.spec.js

Line 29 in 920583f

pruneSessionInterval: false,

Are you sure pruneSessionInterval: false is the cause? I typically go about fixing a bug like this by creating a test case that reproduces the failure and then fixing the code until that test case passes, but in this case there are already test cases that shows that this should be working

[Reiddd]

I'm pretty sure, but your test case looks more persuasive x_x
Anyway, in my product we have bypassed this issue, so I'm ok if you want to close this.
I will keep an eye on this kind of issue in my product to look for the real root cause if there is one

[voxpelli]

Sorry, didn't see your comment before I added the label 🙈 Closing for now then, open a new one if the issue pops up again