Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take a renewed look at close() #14

Open
voxpelli opened this issue Jul 28, 2018 · 1 comment
Open

Take a renewed look at close() #14

voxpelli opened this issue Jul 28, 2018 · 1 comment
Assignees
@voxpelli
Milestone
2.0.0

Comments

@voxpelli
Copy link
Owner

voxpelli commented Jul 28, 2018 •
edited
Loading

It posed a problem when it came to the type linting – didn't really get it to play well with the .close() on a function.

Commented out the code for now. Might just have to readd it and have typescript ignore it for now instead 🤔
@voxpelli voxpelli added this to the 2.0.0 milestone Jul 28, 2018
@voxpelli voxpelli self-assigned this Jul 28, 2018
@voxpelli
Copy link
Owner Author

voxpelli commented Aug 4, 2020

Also: Ensure it is compatible with graceful shutdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@voxpelli voxpelli

Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@voxpelli