User-Defined Environment Variables

[Ginja]

Hi @anodelman,

Thanks for submitting a bug to fix the issue I had in #210. I've tried your patch, and while it's fixed the issue of Beaker not running at all, I'm still seeing some odd behaviour.

Below is what I have in my test file (the nodesets have specific versions of Ruby installed, and I specify what it is through the ruby_version key underneath CONFIG:):

apply_manifest_on hosts, manifest, { :environment => { 'PATH' => "/usr/local/rvm/gems/#{options['ruby_version']}/bin:/usr/local/rvm/gems/#{options['ruby_version']}@global/bin:/usr/local/rvm/rubies/#{options['ruby_version']}/bin:/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/rvm/bin:/root/bin"},
                                     :catch_failures => true }

The above results in this command being executed on my SUTs:

puppet-stack 17:32:01$  env PATH="/usr/local/rvm/gems/ruby-2.0.0-p451/bin:/usr/local/rvm/gems/ruby-2.0.0-p451@global/bin:/usr/local/rvm/rubies/ruby-2.0.0-p451/bin:/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/rvm/bin:/root/bin" PATH="/usr/bin:/opt/puppet-git-repos/hiera/bin:${PATH}" RUBYLIB="/opt/puppet-git-repos/hiera/lib:/opt/puppet-git-repos/hiera-puppet/lib:${RUBYLIB}" puppet apply --verbose --detailed-exitcodes /tmp/apply_manifest.pp.zoNoAW

It looks like PATH is being specified twice, and that what I set isn't taking precedence as I see these warnings still during my SUT's Puppet run.

Warning! PATH is not properly set up, '/usr/local/rvm/gems/ruby-2.0.0-p451/bin' is not at first place,
         usually this is caused by shell initialization files - check them for 'PATH=...' entries,
         it might also help to re-add RVM to your dotfiles: 'rvm get stable --auto-dotfiles',
         to fix temporarily in this shell session run: 'rvm use ruby-2.0.0-p451'.

[anodelman]

This will be fixed in #449