-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
params gem provider logic fails with PE puppet 2015.03 #109
Comments
if $::puppetversion =~ /Puppet Enterprise/ and $::osfamily != 'Windows' {
$gem_provider = 'pe_gem'
} elsif $::aio_agent_version {
$gem_provider = 'puppet_gem'
} else {
if versioncmp($::puppetversion, '4.0.0') >= 0 {
$gem_provider = 'puppet_gem'
} else {
$gem_provider = 'gem'
}
}
The above code seems to work for me. I am not sure when PE puppet stoppped displaying puppet enterprise in the puppetversion though. |
this ticket explains why: I guess the proposed solution is a good one |
Also this issue was recently merged which might change some of the code above. |
Closing due to recently-merged PRs. Please re-open if this is still an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Just downloaded PE 2015.03 and the params code that determines which gem provider to use is not working correctly because $::aio_agent_version does not exist. Maybe this should be a case statement comparing all the versions since PE puppet no longer contains 'puppet enterprise' in the newer versions
https://github.com/voxpupuli/puppet-archive/blob/master/manifests/params.pp#L22
similar to #106 but slightly different
The text was updated successfully, but these errors were encountered: