Why force puppetversion fact everywhere in the archive spec?

[aerostitch]

Hi,

I was wondering why you force the puppetversion fact in spec/classes/archive_spec.rb even for the opensource version of puppet.

It looks a bit weird to test against different versions but to force the version fact in the tests no?

:puppetversion => '3.7.3'

I discovered that because when writing a module that depends on puppet-archive and wrote rspec tests without forcing this fact. In this case, the tests fail with the following error:

error during compilation: Undefined variable "::puppetversion"; Undefined variable "puppetversion" at /home/travis/build/tubemogul/puppet-aerospike/spec/fixtures/modules/archive/manifests/params.pp:22 on node testing-worker-linux-docker-212279d8-3372-linux-8.prod.travis-ci.org

Thanks for your help,
Joseph

[aerostitch]

Answer to myself: It's because rspec-puppet says:

By default, the test environment contains no facts for your manifest to use.

I'll provide a few tests to cover the few more cases we have in params.pp in #117 and it should be fine.
Closing this one as RTFM! ;)