Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid changing configuration when adding optional parameters #64

Closed
vchepkov opened this issue Jan 24, 2020 · 2 comments · Fixed by #79
Closed

avoid changing configuration when adding optional parameters #64

vchepkov opened this issue Jan 24, 2020 · 2 comments · Fixed by #79

Comments

@vchepkov
Copy link
Contributor

Currently, with each new managed parameter, configuration file gets new 'hanging' comments and empty lines, for example:

# Hardware reference clock drivers


# https://chrony.tuxfamily.org/doc/3.4/chrony.conf.html#leapsecmode

# https://chrony.tuxfamily.org/doc/3.4/chrony.conf.html#maxslewrate

# https://chrony.tuxfamily.org/doc/3.4/chrony.conf.html#smoothtime

Conditionals in the template should encompass optional comments and not to add empty lines, causing unnecessary global service restart

@vchepkov vchepkov changed the title avoid changing configuration when adding optional paramaters avoid changing configuration when adding optional parameters Jan 24, 2020
@ekohl
Copy link
Member

ekohl commented Jul 11, 2020

I think #79 changed the line endings to be more consistent. Mind checking if this is still an issue for you?

@ekohl ekohl linked a pull request Jul 11, 2020 that will close this issue
@vchepkov
Copy link
Contributor Author

Yes, template is great now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants