config options in python.conf.erb

[jameseck]

Hi,

Just a quick bug to report.
In the python.conf.erb, the loop over the hash entries is not sorted, so the options are liable to switch order, causing subsequent puppet runs to rewrite the file.

<% @config.each do |key,value| -%>
<%= key -%> "<%= value -%>"
<% end -%>

I've fixed it on my own copy with the following:

<% @config.sort.each do |key,value| -%>
<%= key -%> "<%= value -%>"
<% end -%>

Apart from this small issue, the module is great btw :)

[cmurphy]

Thanks! Want to make a pull request with your change?

[jameseck]

I would if I knew how :)
It's a pretty simple change though.

[blkperl]

Github has excellent docs on how to create a pull request. Let us know if you get stuck.

https://help.github.com/articles/creating-a-pull-request

[jameseck]

Hi
I've finally worked out how to submit a PR. I presume I've done it the right way (forked the repo and raised a PR from a branch on my fork).

[txaj]

Since the patch has been included, can this issue be closed ? thanks

[blkperl]

Yes thanks for pointing this out.