Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template in collectd::plugin::perl::plugin generates unstable output #635

Closed
blajos opened this issue Jan 23, 2017 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@blajos
Copy link

blajos commented Jan 23, 2017

Hi,

We are using collectd::plugin::perl::plugin to collect data from some rabbitmq servers. But the generated config file is changing regurarly.

The simplest solution would be to use sort on hashes in file templates/plugin/perl/plugin.erb.

Thanks,
Lajos

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 3.8.7
  • Ruby: 1.8.7
  • Distribution: CentOS 6/7
  • Module version: 4.2.0

How to reproduce (e.g Puppet code you use)

  collectd::plugin::perl::plugin { 'RabbitMQ':
    module      => 'RabbitMQ',
    include_dir => '/usr/local/collectd',
    provider    => 'file',
    source      => 'puppet:///files/usr/local/collectd/RabbitMQ.pm',
    destination => '/usr/local/collectd',
    config      => {
      'Username' => 'collectd',
      'Password' => 'very_secure',
      'Port'     => 15672,
      'Host'     => 'localhost',
      'Realm'    => 'RabbitMQ Management',
    },
    require     => File['/usr/local/collectd'],
  }

What are you seeing

Config lines move around regurarly on puppet runs.

What behaviour did you expect instead

Config lines should stay put.

Output log

Any additional information you'd like to impart

Used versions are pretty old, but the current code still has the same issue.

@oranenj
Copy link
Contributor

oranenj commented Apr 10, 2017

I'll assume this is fixed and close this issue, because the PR is merged

@oranenj oranenj closed this as completed Apr 10, 2017
@oranenj oranenj added the bug Something isn't working label Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants