Add support for CNI plugins

[spuder]

https://www.nomadproject.io/guides/integrations/consul-connect/index.html#cni-plugins

The CNI plugins are needed for consul connect.
To install it, run these commands

$ curl -L -o cni-plugins.tgz https://github.com/containernetworking/plugins/releases/download/v0.8.1/cni-plugins-linux-amd64-v0.8.1.tgz
$ sudo mkdir -p /opt/cni/bin
$ sudo tar -C /opt/cni/bin -xzf cni-plugins.tgz

Should the puppet module install these plugins?

[bastelfreak]

Hi. As long as this is an opt-in feature I would be fine with it. Are you interested in providing a pull request for this?

[spuder]

My puppet is a bit rusty, so I'm not sure the correct approach for implementing this feature.

Option 1.

Create manifests/cni.pp and conditionally include the manifest

Option 2.

Add the installation to manifests/install.pp and wrap inside a variable check

if $manage_cni
  file {'/opt/cni:
  ...  
  }
...
end

Option 3.

Let the end users manage it themselves in their own profile

I've got the following working inside my profile

  file { '/opt/cni':
    ensure => directory,
    owner => 'nomad',
    group => 'nomad',
  } ->
  file { '/opt/cni/bin':
    ensure => directory,
    owner => 'nomad',
    group => 'nomad',
  } ->
  archive { 'cni-plugins':
    path => '/tmp/cni-plugins.tgz',
    source => 'https://github.com/containernetworking/plugins/releases/download/v0.8.1/cni-plugins-linux-amd64-v0.8.1.tgz',
    extract => true,
    extract_path => '/opt/cni/bin/',
    cleanup => true,
    creates => '/opt/cni/bin/flannel'
  } 

[solarkennedy]

I don't think this should be part of this module. These binaries are not consul-specific, they just happen to be commands that consul could run if you asked it to.

I think it should be a different puppet module.