Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module doesn't support grpc checks #630

Closed
tedkozma opened this issue Aug 4, 2023 · 0 comments · Fixed by #648
Closed

module doesn't support grpc checks #630

tedkozma opened this issue Aug 4, 2023 · 0 comments · Fixed by #648

Comments

@tedkozma
Copy link

tedkozma commented Aug 4, 2023

the consul::validate_checks function doesn't support grpc checks

  • Puppet: 6.28.0
  • Ruby: ruby 2.7.0p0 (2019-12-25 revision 647ee6f091) [x86_64-linux-gnu]
  • Distribution: Ubuntu 20.04.6 LTS
  • Module version: 7.3.1

How to reproduce (e.g Puppet code you use)

Try to set a check:

consul::services:
  'somegrpcservice':
    address: "%{facts.networking.ip}"
    checks:
      - name: 'check-somegrpcservice'
        grpc: "127.0.0.1:6000"
        grpc_use_tls: false
        interval: 10s
    port: 42
    tags:
      - 'sometag'
    meta:
      SLA: 1

What are you seeing

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Function Call, One of ttl, script, tcp, or http must be defined. (file: /etc/puppetlabs/code/environments/staging/modules/consul/manifests/service.pp, line: 106, column: 3)

What behaviour did you expect instead

I expect this to set up a grpc check I know consul supports. It works when I set it manually, without puppet.

Output log

Any additional information you'd like to impart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants