Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decorate method in templates/gitlab.rb.erb file may break some thing #146

Closed
yasserzamani opened this issue Jul 11, 2017 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@yasserzamani
Copy link

For example:
gitlab_rails => {smtp_password => '12345'}
generates
gitlab_rails['smtp_password'] = 12345
which is wrong because password is a string not number and this does not work in sending email (throws an exception)!

@davidgubler
Copy link
Contributor

I think the decorate() method is only needed in its current form because of Puppet 3's broken type handling (Puppet 3 converts integers to strings in some cases where it shouldn't). Thus I think we can improve it once we drop Puppet 3 support (which, unfortunately, we can't do just yet - but it's in progress).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants