Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yum repo is incompatible for Amazon Linux #46

Closed
cagriersen opened this issue Dec 23, 2015 · 5 comments
Closed

yum repo is incompatible for Amazon Linux #46

cagriersen opened this issue Dec 23, 2015 · 5 comments
Labels
needs-help Extra attention is needed

Comments

@cagriersen
Copy link

Although Amazon Linux is based on RHEL, they're using different release naming schema than RHEL and therefor this module seems incompatible for Amazon AMI.

I think, OS selection case should be modified as includes Amazon Linux $::operatingsystemmajrelease value.

Here is an example facter output from an Amazon AMI:

operatingsystem => Amazon
operatingsystemmajrelease => 2015
operatingsystemrelease => 2015.09
@tobru
Copy link
Contributor

tobru commented Dec 24, 2015

Thanks for your suggestion. Would you mind creating a tested PR for this? That would make things easier as I don't have access atm to an Amazon AMI to test it.

@cagriersen
Copy link
Author

Hi again,

I've just modified the code -in a dirty way- to quick fixing:

        if ($::operatingsystem == 'Redhat' and ($::operatingsystemmajrelease == '6' or $::operatingsystemmajrelease == '7')) {
          $releasever = $::operatingsystemmajrelease
        } elsif ($::operatingsystem == 'Amazon' and $::operatingsystemmajrelease == '2015') {
          $releasever = '6'
        }

@tobru
Copy link
Contributor

tobru commented Jan 22, 2016

Would you mind creating a PR for this changes?

@tobru
Copy link
Contributor

tobru commented Mar 11, 2016

@cagriersen Is this still an issue? If yes, would you mind creating a PR?

@tobru tobru added the needs-help Extra attention is needed label Mar 23, 2016
@tobru
Copy link
Contributor

tobru commented Aug 10, 2016

As I don't have an Amazon AMI available right now to test this issue and no tested PR has been made, I'll close this issue for now. If someone is able to provide a proper PR, I'm happy to merge it to have support for Amazon Linux.

@tobru tobru closed this as completed Aug 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-help Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants