Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid parameter registry_external_url on Class[Gitlab] #81

Closed
VAdamec opened this issue Jun 13, 2016 · 1 comment
Closed

Invalid parameter registry_external_url on Class[Gitlab] #81

VAdamec opened this issue Jun 13, 2016 · 1 comment

Comments

@VAdamec
Copy link

VAdamec commented Jun 13, 2016

Could not find option how to add "registry_external_url" to gitlab.rb config.

  class { 'gitlab':
    external_url => "https://git-ig.cz.avg.com",
    registry_external_url => "https://git-ig.cz.avg.com:4567",
...
  }

with Hiera

  • ignored:
gitlab:
  registry_external_url: "https://git-ig.cz.avg.com:4567"

This affect rails hash, but of course is not valid for gitlab setup

gitlab::gitlab_rails:
  webhook_timeout: 10
  gitlab_default_theme: 2
  registry_external_url: "https://git-ig.cz.avg.com:4567"
 ...

creates:

gitlab_rails['registry_external_url'] = 'https://git-ig.cz.avg.com:4567'

Expected result:

  • /etc/gitlab/gitlab.rb
external_url 'https://git-ig.cz.avg.com'
registry_external_url "https://git-ig.cz.avg.com:4567"

############################
# gitlab.yml configuration #
############################

gitlab_rails['gitlab_default_theme'] = 2
...

Config

  • 1.8.0 puppet module version
  • centos 7, latest Gitlab CE
@tobru
Copy link
Contributor

tobru commented Jun 14, 2016

This has been fixed in #76 - new release of the module is pending

@tobru tobru closed this as completed Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants