Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex doesn't match double digit version numbers #162

Closed
gnif opened this issue Apr 1, 2018 · 1 comment
Closed

Regex doesn't match double digit version numbers #162

gnif opened this issue Apr 1, 2018 · 1 comment

Comments

@gnif
Copy link
Contributor

gnif commented Apr 1, 2018

If version is set to 3.12 the regex match fails as it doesn't account for double digit version numbers:

if $version =~ /^\d\.\d$/ {

This should be:

if $version =~ /^\d+\.\d+$/ {

@ekohl
Copy link
Member

ekohl commented Apr 3, 2018

Would you be willing to submit that as a PR? That way we can properly attribute the change to you. Github even has a neat edit button at https://github.com/voxpupuli/puppet-gluster/blob/master/manifests/repo/apt.pp so you can do it through the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants