Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

register-unsafely-without-email config key is kept when turning unsafe_registration back to false #286

Closed
neomilium opened this issue May 3, 2022 · 0 comments · Fixed by #287

Comments

@neomilium
Copy link
Contributor

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 6/7
  • Distribution: Tested on Debian, all affected
  • Module version: 8.0.2

How to reproduce (e.g Puppet code you use)

First, apply a simple catalog using unsafe_registration sets to true

class { 'letsencrypt':
  unsafe_registration => true,
}

Next apply a catalog using unsafe_registration sets to false

class { 'letsencrypt':
  email => 'hello@example.com',
}

What are you seeing

register-unsafely-without-email is set to true in config file.

What behaviour did you expect instead

No register-unsafely-without-email in config file, or set to false.

Any additional information you'd like to impart

PR is coming…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants