-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge in flymake-puppet? #116
Comments
I've opened issue grimradical/puppet-flymake#2 on the other side to see if they're interested... |
Hi @anarcat. I would be fine with merging it, but I don't know enough the project and emacs to make this properly. Can you propose a PR for this? |
i think it's just a matter of copying the file over, but i must admit i'm not sure myself. |
I took a quick look at puppet-flymake and noticed one possible blocker and one possible TODO. tldr; skip to the end. The possible blocker: The possible TODO: the I found this substantially similar (and newer) project, also based on flymake-coffee: https://github.com/benprew/flymake-puppet. It declares GPL-3+, but also doesn't credit flymake-coffee authors in its copyright statement. Flymake-puppet is also on MELPA unstable (https://melpa.org/#/flymake-puppet), and has a decent number of users (59th percentile), so I feel like it might be a better source to merge. That said, it's now abandoneware "Deprecated in favor of: flycheck-puppet". @anarcat, how do you feel about using flycheck? ISTM that flycheck+user config could solve this. |
Another option, for the sake of completeness: Use https://github.com/purcell/flymake-easy to generate the flymake bits and integrate, thus reducing the number of copyright holders, which means fewer |
On 2019-03-10 19:51:54, Nicholas D Steeves wrote:
I took a quick look at puppet-flymake and noticed one possible blocker and one possible TODO. tldr; skip to the end.
The possible blocker: `puppet-flymake` doesn't have a copyright or license statement (eg: author retains ). That said, it asserts it "is mostly based on flymake-coffee" (GPL-3+). If the number of changes is small enough to not be significant for the purposes of copyright, then the file can be copied and pasted, Deepak retained as an author (in the headers) but not as a copyright holder.
The possible TODO: the `puppet-mode-hook` design might need to be changed.
I found this substantially similar (and newer) project, also based on flymake-coffee: https://github.com/benprew/flymake-puppet. It declares GPL-3+, but also doesn't credit flymake-coffee authors in its copyright statement. Flymake-puppet is also on MELPA unstable (https://melpa.org/#/flymake-puppet), and has a decent number of users (59th percentile), so I feel like it might be a better source to merge. That said, it's now abandoneware "Deprecated in favor of: flycheck-puppet".
@anarcat, how do you feel about using flycheck? ISTM that
flycheck+user config could solve this.
quite frankly, I don't care whatever works. flymake-puppet doesn't quite
work here anyways, in my tests. :p But that could probably fixed without
going through a rewrite...
@bastelfreak, en lieu of putting the burden on the user, `puppet-mode`
can have an optional dependency on flycheck is flycheck is found, and
echo something like "Please install flycheck for enhanced syntax
checking" to the minibuffer. @anarcat, in this case I'd add a
Recommends flycheck to the Debian package and everything work Just
Work™. @bastelfreak, of course if you'd like to push all users to use
flycheck you can use a hard requires, but I like the maximal user
freedom of the former approach.
That all looks good to me. :) I wasn't aware of flycheck... I'm not sure
it's worth the switch, especially since it seems it will *never* replace
flymake within Emacs, but as I said: whatever works is fine by me.
a.
…--
La dictature c'est ferme ta gueule.
La démocratie c'est cause toujours!
- Jean-Louis Barrault
|
Quick update: I just installed flycheck, and it seems to support puppet manifests out of the box. So forget about flymake-puppet altogether - it's not necessary anymore. I'm closing this ticket. :) Sorry for the noise! |
I'm a bit late to this party, but here's my two cents; |
would it be a good idea to merge flymake-puppet into this repository?
https://github.com/grimradical/puppet-flymake
It's 35 lines of code to enable flymake integration... seems like it would be a great improvement at little cost, especially since it doesn't seem to be maintained on its own.
Thanks for your work!
The text was updated successfully, but these errors were encountered: