Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Improve SSL support #599

Closed
5 tasks done
3flex opened this issue Apr 10, 2015 · 1 comment · Fixed by #623
Closed
5 tasks done

[WIP] Improve SSL support #599

3flex opened this issue Apr 10, 2015 · 1 comment · Fixed by #623

Comments

@3flex
Copy link
Contributor

3flex commented Apr 10, 2015

I intend to open a PR to address several open tickets related to SSL in this module.

Target issues:

Target PRs (will update and consolidate):

People have asked for:

  1. Creating cert/key files based on cert/key data that is stored in hiera
  2. Having a configurable directory for SSL cert/key storage, but not changing other functionality the module provides.
  3. Not copying SSL keys around as the module currently does

The simplest thing IMHO is for this module to reference the filename of the certificate and key, and rely on the user to create the files however they choose. They can create files based on hiera data (would require a small bit of custom code), manually or using a companion module like camptocamp/openssl.

I don't think any kind of SSL key management should be part of the scope of this module. Comments welcome! I'll wait for rough consensus before changing anything there.

@3flex 3flex added enhancement New feature or request and removed enhancement New feature or request labels Apr 13, 2015
@3flex 3flex mentioned this issue May 6, 2015
@jfryman
Copy link
Contributor

jfryman commented May 9, 2015

I don't think any kind of SSL key management should be part of the scope of this module.

Absolutely. When I added SSL management early on, there really wasn't another option and was a great way to bootstrap for testing. However, it's been used in tons of unintended ways in production scenarios. This is some good debt to start hacking at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants