Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency cycle on ubuntu 14.04 #281

Closed
pscadiz opened this issue Feb 23, 2017 · 8 comments
Closed

Dependency cycle on ubuntu 14.04 #281

pscadiz opened this issue Feb 23, 2017 · 8 comments
Labels
bug Something isn't working wont-fix This will not be worked on

Comments

@pscadiz
Copy link

pscadiz commented Feb 23, 2017

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 3.8
  • Ruby: 2.0.0
  • Distribution: Ubuntu 14.04 (Trusty)
  • Module version: (used latest commit)

How to reproduce (e.g Puppet code you use)

class { '::nodejs':
}

What are you seeing

Puppet fails to run with a dependency cycle

What behaviour did you expect instead

Node to be installed

Output log

Error: Could not apply complete catalog: Found 1 dependency cycle
(Anchor[::nodejs::begin] => Class[Nodejs::Repo::Nodesource] => Class[Nodejs::Repo::Nodesource::Apt] => Apt::Source[nodesource] => Apt::Setting[list-nodesource] => File[/etc/apt/sources.list.d/nodesource.list] => Class[Apt::Update] => Exec[apt_update] => Class[Apt::Update] => Stage[setup] => Stage[main] => Class[Nodejs::Repo::Nodesource])

Any additional information you'd like to impart

Running puppet on a docker container based on atlassian/bamboo-base-agent. Also updated puppetlabs-apt to tag 2.3.0

@ghost
Copy link

ghost commented Mar 3, 2017

👍
Confirmed on :

  • Puppet: 3.8.6
  • Ruby: 2.3.1
  • Distribution: Ubuntu 16.04 (Xenial)
  • Module version: 2.3.0
  • puppetlabs-apt at 2.3.0
  • not running on a docker container
  • also happens when using repo_url_suffix => '6.x',

@ghost
Copy link

ghost commented Mar 10, 2017

hey! Any update or ETA on this?

@bastelfreak
Copy link
Member

Hi @pscadiz and @zehzehpeh. Thanks for reporting this error. Is one of you able to provide a patch for this?

@bastelfreak bastelfreak added the bug Something isn't working label Mar 11, 2017
@ghost
Copy link

ghost commented Mar 14, 2017

@bastelfreak unfortunately I am not able to invest much time in this at the moment. However, I'd be more than happy to test any patch you send my way.

@ghost ghost mentioned this issue Mar 23, 2017
@ffrank
Copy link
Contributor

ffrank commented Apr 11, 2017

I'd love to see this fixed, but please note that Puppet 3.x is not supported by this module anymore. The issue appears to not be reproducible w/ Puppet 4.x.

Is a Puppet upgrade an option for you at all?

@ghost
Copy link

ghost commented Apr 18, 2017

Puppet 3.x is not supported by this module anymore.

Fair enough.

Is a Puppet upgrade an option for you at all?

I am currently trying to confirm the issue is indeed because of Puppet 3.x by testing the same role in Puppet 4.x. If this is confirmed, the PR should be rejected. I will update this ticket and the PR accordingly.

@ghost
Copy link

ghost commented Apr 19, 2017

As commented in the PR, it seems the problem is indeed related to Puppet 3 vs 4.

@ffrank
Copy link
Contributor

ffrank commented Apr 19, 2017

Thanks for the feedback.

Closing this as WONTFIX.

@ffrank ffrank closed this as completed Apr 19, 2017
@juniorsysadmin juniorsysadmin added the wont-fix This will not be worked on label Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wont-fix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants