Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code not in sync with puppet Forge? #84

Closed
SirDice opened this issue Oct 25, 2017 · 3 comments
Closed

Code not in sync with puppet Forge? #84

SirDice opened this issue Oct 25, 2017 · 3 comments

Comments

@SirDice
Copy link

SirDice commented Oct 25, 2017

It looks like the forge.puppet.com module is the code from 1.1.1 but with a 1.2.0 version string. Something doesn't add up.

puppet module install --modulepath /usr/local/etc/puppet/code/site_modules zleslie-pkgng

If I look at the first few lines of manifests/init.pp from the Forge module:

class pkgng (
  Pattern[/^\/.*/] $pkg_dbdir     = $pkgng::params::pkg_dbdir,
  Pattern[/^\/.*/] $pkg_cachedir  = $pkgng::params::pkg_cachedir,
  Pattern[/^\/.*/] $portsdir      = $pkgng::params::portsdir,
  Array            $options       = [],
  Boolean          $purge_repos_d = true,
  Hash             $repos         = {},
) inherits pkgng::params {

Whereas the Github code shows:

class pkgng (
  Stdlib::Absolutepath $pkg_dbdir     = $pkgng::params::pkg_dbdir,
  Stdlib::Absolutepath $pkg_cachedir  = $pkgng::params::pkg_cachedir,
  Stdlib::Absolutepath $portsdir      = $pkgng::params::portsdir,
  Array[String]        $options       = [],
  Boolean              $purge_repos_d = true,
  Hash                 $repos         = {},
) inherits pkgng::params {

I noticed this difference because my Puppet installation kept adding WITH_PKGNG=YES to make.conf over and over again. Which is the behavior of 1.1.1.

@SirDice
Copy link
Author

SirDice commented Oct 25, 2017

Oh, my dyslexia... Version on Github is 2.1.0, Puppet Forge version is 1.2.0.

Any chance the version on Forge will be update soon? I now have the Github 2.1.0 version running and it looks to be working correctly.

@zachfi
Copy link
Contributor

zachfi commented Oct 25, 2017

Hi, thanks for the report. I'm bad at keeping the forge updated. I'll take a look at updating the forge for my modules in the coming evenings.

@zachfi
Copy link
Contributor

zachfi commented Oct 26, 2017

The forge has been updated for this module.

@zachfi zachfi closed this as completed Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants