Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Extend File type to eliminate need for redundant code #16

Closed
dobbymoodge opened this issue Sep 22, 2015 · 2 comments
Closed

[RFE] Extend File type to eliminate need for redundant code #16

dobbymoodge opened this issue Sep 22, 2015 · 2 comments
Labels
enhancement New feature or request

Comments

@dobbymoodge
Copy link

Currently, the Acl type only operates on files and directories that exist. This means that a matching File resource is needed to guarantee that the Acl resource requirements are met. This also means that the mode property for the File resource must match the three base entries in the Acl permission property. See: https://github.com/dobbymoodge/puppet-acl#conflicts-with-file-resource-type

I propose that the Acl type be modified to extend the File type, so that all the properties available in the File type are exposed or overridden by the Acl type. I think this should be straightforward, but some properties may conflict (i.e. the Acl {'permission'} and File {'mode'} properties). These need to be specifically addressed:

  • The mode property will not be exposed, and the values for the base entries in the Acl {'permission'} property will be used internally to supply File {'mode'}
  • The File {'recurselimit'} property will need a matching, overriding implementation in the Acl type.
  • ???
@roidelapluie
Copy link
Member

  • Will require precise puppet compatibility in the metadata.json and tests against each version of puppet, preferably beaker tests.

@dobbymoodge dobbymoodge added the enhancement New feature or request label Oct 27, 2016
@ghoneycutt
Copy link
Member

Closing due to age of issue. Please re-open with a pull request if you would like this enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants