Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch signing keys from GitHub or Bintray #781

Open
michaelklishin opened this issue Mar 15, 2019 · 6 comments
Open

Fetch signing keys from GitHub or Bintray #781

michaelklishin opened this issue Mar 15, 2019 · 6 comments
Labels
enhancement New feature or request

Comments

@michaelklishin
Copy link

This module downloads signing key from rabbitmq.com. Team RabbitMQ deprecated downloads from rabbitmq.com a couple of years ago (see Signatures). Why? We don't want to be distributing artifacts, there are services that do it better.

The key is available from Bintray and GitHub. Please switch to one of those locations.

The current key isn't going to be removed from rabbitmq.com but when it's time to renew, it may or may not make the cut.

@wyardley
Copy link
Contributor

Are there any releases for which F4E789204D206F89 is still valid, and if so, is that accessible from anywhere?

@michaelklishin
Copy link
Author

@wyardley we've migrated to the new key about 3 years ago (mailing list announcement). 3.5.8 and early 3.6.x releases were all signed with the new key. We re-signed even legacy apt repositories on rabbitmq.com IIRC.

The old key is available from Bintray. I honestly thing we can consider it to be irrelevant.

@wyardley
Copy link
Contributor

wyardley commented Mar 29, 2019

@michaelklishin I have to double check - module’s default behavior actually ships 3.3.x (from the vendors’ repos) on certain platforms, tho I guess in that case it will probably be signed with the vendor’s key? I feel like there’s a reason that we have the old key imported in one or two places, but could be wrong.

@juniorsysadmin juniorsysadmin added the enhancement New feature or request label Mar 31, 2019
@juniorsysadmin
Copy link
Member

Ideally the public key should be included with this module and not fetched as well.

@wyardley
Copy link
Contributor

wyardley commented Apr 3, 2019

@juniorsysadmin I agree that that's probably the most secure way. Do you have time / inclination to throw up a PR to switch it to this pattern?

@juniorsysadmin
Copy link
Member

@wyardley I have sadly not much time for this at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants