Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to disable slowlog_log_slower_than #404

Closed
mattpascoe opened this issue Jul 12, 2021 · 0 comments · Fixed by #414
Closed

Ability to disable slowlog_log_slower_than #404

mattpascoe opened this issue Jul 12, 2021 · 0 comments · Fixed by #414
Labels
enhancement New feature or request

Comments

@mattpascoe
Copy link

mattpascoe commented Jul 12, 2021

Currently the code requires an integer for slowlog_log_slower_than as indicated here:

Integer[0] $slowlog_log_slower_than = 10000,

However there are times you would want to disable slowlog all together. The way to do this is to pass in '-1' which puppet complains is not an integer.

Please allow for '-1' values in this field. I'm not sure if there are other features that can be disabled in this way, so that might be worth a look?

For reference on the disable option: https://help.compose.com/docs/redis-slow-logs#slowlog-log-slower-than

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants