Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing WorkingDirectory parameter on Systemd::Unit::Service #320

Closed
hboetes opened this issue Feb 23, 2023 · 6 comments
Closed

Missing WorkingDirectory parameter on Systemd::Unit::Service #320

hboetes opened this issue Feb 23, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@hboetes
Copy link

hboetes commented Feb 23, 2023

Hi there,

I just tried to generate a systemd file and got the message that WorkingDirectory= and User= were unknown options for the service section, so I added them in types/unit/service.pp, like so:

    Optional['WorkingDirectory']          => String,
    Optional['User']                      => String,

After things worked fine again. But… am I missing something or are those options really missing. They are documented: https://www.freedesktop.org/software/systemd/man/systemd.exec.html

Thanks!
@kenyon
Copy link
Member

kenyon commented Feb 23, 2023

As said in #288

Not every systemd directive has been added but a healthy set has and subsequents can be added as required.

@smortex
Copy link
Member

smortex commented Feb 23, 2023

👋 @hboetes

Please send these changes as a Pull-Request 😉

@jhoblitt
Copy link
Member

jhoblitt commented Mar 1, 2023

Related to #321

@ekohl ekohl changed the title Are those really missing or am I missing something? Missing User and WorkingDirectory parameters on Systemd::Unit::Service Mar 20, 2023
@ekohl ekohl linked a pull request Mar 20, 2023 that will close this issue
Add User, Group, StandardOutput and StandardError services. #321
Closed
@ekohl
Copy link
Member

ekohl commented Mar 20, 2023 •
edited

Duplicates #299

@ekohl ekohl closed this as completed Mar 20, 2023
@ekohl ekohl removed a link to a pull request Mar 20, 2023
Add User, Group, StandardOutput and StandardError services. #321
Closed
@kenyon kenyon added the duplicate This issue or pull request already exists label Mar 20, 2023
@ekohl
Copy link
Member

ekohl commented Mar 21, 2023

Actually going to reopen this and scope it down to just WorkingDirectory.

@ekohl ekohl reopened this Mar 21, 2023
@ekohl ekohl changed the title Missing User and WorkingDirectory parameters on Systemd::Unit::Service Missing WorkingDirectory parameter on Systemd::Unit::Service Mar 21, 2023
@ekohl ekohl added enhancement New feature or request and removed duplicate This issue or pull request already exists question labels Mar 21, 2023
@ekohl ekohl linked a pull request Mar 21, 2023 that will close this issue
Add User, Group, StandardOutput and StandardError services. #321
Closed
@traylenator
Copy link
Contributor

WorkingDirectory was added in c785f4f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add User, Group, StandardOutput and StandardError services. bschonec/puppet-systemd
6 participants
@kenyon @traylenator @smortex @ekohl @jhoblitt @hboetes